Date: Fri, 12 Jul 2019 07:44:16 -0400 From: Randall Stewart <rrs@netflix.com> To: Enji Cooper <yaneurabeya@gmail.com> Cc: Randall Ray Stewart <rrs@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349907 - head/sys/netinet/tcp_stacks Message-ID: <9849A15D-6934-4076-9FE9-80AF28F8376C@netflix.com> In-Reply-To: <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com> References: <201907110438.x6B4cXX1054795@repo.freebsd.org> <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com>
index | next in thread | previous in thread | raw e-mail
opps.. that was a error on my part I will fix it :) > On Jul 11, 2019, at 4:37 AM, Enji Cooper <yaneurabeya@gmail.com> wrote: > > >> On Jul 10, 2019, at 9:38 PM, Randall Stewart <rrs@freebsd.org> wrote: >> >> Author: rrs >> Date: Thu Jul 11 04:38:33 2019 >> New Revision: 349907 >> URL: https://svnweb.freebsd.org/changeset/base/349907 >> >> Log: >> Update copyright per JBH's suggestions.. thanks. >> >> Modified: >> head/sys/netinet/tcp_stacks/rack.c >> >> Modified: head/sys/netinet/tcp_stacks/rack.c >> ============================================================================== >> --- head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 03:29:25 2019 (r349906) >> +++ head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 04:38:33 2019 (r349907) >> @@ -1,5 +1,5 @@ >> /*- >> - * Copyright (c) 2016 >> + * Copyright (c) 2016-2019 >> * Netflix Inc. All rights reserved. >> * >> * Redistribution and use in source and binary forms, with or without >> @@ -8537,10 +8537,10 @@ out: >> * retransmit. In persist state, just set snd_max. >> */ >> if (error == 0) { >> -/* if (TCPS_HAVEESTABLISHED(tp->t_state) && >> + if (TCPS_HAVEESTABLISHED(tp->t_state) && >> (tp->t_flags & TF_SACK_PERMIT) && >> tp->rcv_numsacks > 0) >> - tcp_clean_dsack_blocks(tp);*/ >> + tcp_clean_dsack_blocks(tp); > > Removing this commented out code unfortunately broke the build: https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/12934/console . > Thanks, > -Enji > ------ Randall Stewart rrs@netflix.comhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9849A15D-6934-4076-9FE9-80AF28F8376C>