Date: Mon, 11 Mar 2019 16:32:01 +0900 From: Koichiro Iwao <meta@FreeBSD.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495326 - in head/textproc/kibana6: . files Message-ID: <20190311073200.4tvhu6rcam2ipiv4@icepick.vmeta.jp> In-Reply-To: <20190311063230.GA62788@urd.tobik.me> References: <201903110543.x2B5hKYs027206@repo.freebsd.org> <20190311063230.GA62788@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 11, 2019 at 07:32:31AM +0100, Tobias Kortkamp wrote:
> > @@ -35,14 +35,17 @@ do-install:
> > ${RM} -r config node optimize && \
> > ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR})
> > ${INSTALL} -lrs ${STAGEDIR}${ETCDIR} ${STAGEDIR}${WWWDIR}/config
> > - ${CHMOD} +x ${STAGEDIR}${WWWDIR}/bin/*
> >
> > post-install:
> > ${ECHO} "@sample ${ETCDIR}/kibana.yml.sample" >> ${TMPPLIST}
> > ${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \
> > ${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST}
> > + ${REINPLACE_CMD} -e "s|\(${WWWDIR}/bin/.*\)|@mode 0755 \1|" ${TMPPLIST}
>
> I'm sorry, but this is probably wrong and a noop. There are no
> entries starting with WWWDIR in TMPPLIST (${PREFIX} is stripped
> from entries in the ${FIND} line above it). I guess it should be
> WWWDIR_REL here. @mode also does not take a file argument. Though
> that problem is of course never triggered. See pkg-create(8):
Indeed, thanks. I meant WWWDIR_REL here but I wasn't aware it is noop.
Alternatively, I think COPYTREE_BIN or INSTALL_PROGRAM is another
option.
> What was wrong with using CHMOD?
Actually nothing's going wrong but portlint warned. I aporogize for over
optimization.
--
meta <meta@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190311073200.4tvhu6rcam2ipiv4>