Date: Tue, 7 Jan 2020 16:07:31 +0000 (UTC) From: Mark Johnston <markj@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356445 - head/sys/dev/smartpqi Message-ID: <202001071607.007G7VBl056370@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: markj Date: Tue Jan 7 16:07:30 2020 New Revision: 356445 URL: https://svnweb.freebsd.org/changeset/base/356445 Log: Decrease logging severity when adding a device or reading config table. In PR 243056 a user reports some spam from smartpqi(4). In particular, the driver warns about an unrecognized PQI_CONF_TABLE_SECTION_SOFT_RESET section (not yet defined in the driver, but handled in Linux), but this doesn't cause any problems. The Linux driver also does not warn about unrecognized sections. Also do not log a warning when a device is added, since this is routine. Lower severity to DISC, to match pqisrc_remove_device(). PR: 243056 Reviewed by: sbruno MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D23023 Modified: head/sys/dev/smartpqi/smartpqi_discovery.c head/sys/dev/smartpqi/smartpqi_init.c Modified: head/sys/dev/smartpqi/smartpqi_discovery.c ============================================================================== --- head/sys/dev/smartpqi/smartpqi_discovery.c Tue Jan 7 16:03:11 2020 (r356444) +++ head/sys/dev/smartpqi/smartpqi_discovery.c Tue Jan 7 16:07:30 2020 (r356445) @@ -1213,7 +1213,7 @@ static int pqisrc_add_device(pqisrc_softstate_t *softs pqi_scsi_dev_t *device) { DBG_FUNC("IN\n"); - DBG_WARN("vendor: %s model: %s bus:%d target:%d lun:%d is_physical_device:0x%x expose_device:0x%x volume_offline 0x%x volume_status 0x%x \n", + DBG_DISC("vendor: %s model: %s bus:%d target:%d lun:%d is_physical_device:0x%x expose_device:0x%x volume_offline 0x%x volume_status 0x%x \n", device->vendor, device->model, device->bus, device->target, device->lun, device->is_physical_device, device->expose_device, device->volume_offline, device->volume_status); device->invalid = false; Modified: head/sys/dev/smartpqi/smartpqi_init.c ============================================================================== --- head/sys/dev/smartpqi/smartpqi_init.c Tue Jan 7 16:03:11 2020 (r356444) +++ head/sys/dev/smartpqi/smartpqi_init.c Tue Jan 7 16:07:30 2020 (r356445) @@ -453,7 +453,7 @@ int pqisrc_process_config_table(pqisrc_softstate_t *so ret = PQI_STATUS_SUCCESS; break; default: - DBG_ERR("unrecognized PQI config table section ID: 0x%x\n", + DBG_INFO("unrecognized PQI config table section ID: 0x%x\n", LE_16(section_hdr->section_id)); break; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001071607.007G7VBl056370>