Date: Fri, 17 May 2019 19:28:08 +0000 From: "v.maffione_gmail.com (Vincenzo Maffione)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-virtualization@freebsd.org Subject: [Differential] D20276: [bhyve][virtio-net] Allow guest VM's to set JUMBO MTU in case of using the VALE switch. Message-ID: <3400517f1b5fe7b6adcfbb3763db481d@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-pueoqfdkfh54jyuh6emz-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-pueoqfdkfh54jyuh6emz-req@reviews.freebsd.org>
index | next in thread | previous in thread | raw e-mail
v.maffione_gmail.com added inline comments.
INLINE COMMENTS
> aleksandr.fedorov_itglobal.com wrote in pci_virtio_net.c:407
> I drop it to simplify the code under the assumption that current setup code
>
> void
> pci_vtnet_netmap_setup(struct pci_vtnet_softc *sc, char *ifname)
> {
> ...
> sc->vsc_nmd = nm_open(ifname, NULL, 0, 0);
> ...
> }
>
> always sets the number of TX/RX rings to one. And there is no way to change it using bhyve(8).
>
> In the future, I want to replace the legacy API and add the ability to specify not only the VALE switch, but also other types of netmap ports, and return the iteration through the rings.
>
> Or I can return this code now. What do you think?
That's fine. But still you need to replace cur_rx_ring with cur_tx_ring, for consistency.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D20276/new/
REVISION DETAIL
https://reviews.freebsd.org/D20276
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: aleksandr.fedorov_itglobal.com, #bhyve, jhb, rgrimes, krion, v.maffione_gmail.com
Cc: mizhka_gmail.com, novel, olevole_olevole.ru, freebsd-virtualization-list, evgueni.gavrilov_itglobal.com, bcran
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3400517f1b5fe7b6adcfbb3763db481d>