Date: Tue, 27 Nov 2001 17:14:35 -0500 From: "Dan Langille" <dan@langille.org> To: Mike Barcroft <mike@FreeBSD.ORG> Cc: des@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: Meaningless commit messages [was: cvs commit: ports/www/linux-opera Makefile] Message-ID: <3C03C9FB.9843.13B7AD51@localhost> In-Reply-To: <20011127163513.A12400@espresso.q9media.com> References: <200111272030.WAA04863@ipcard.iptcom.net>; from sobomax@FreeBSD.org on Tue, Nov 27, 2001 at 10:30:14PM %2B0200
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 Nov 2001 at 16:35, Mike Barcroft wrote: > Maxim Sobolev <sobomax@FreeBSD.org> writes: > > On Tue, 27 Nov 2001 09:49:16 -0800 (PST), Dag-Erling Smorgrav wrote: > > > des 2001/11/27 09:49:16 PST > > > > > > Modified files: > > > www/linux-opera Makefile > > > Log: > > > Pander to the backseat drivers. > > > > Could you please use more meaningful commit messages? For > > example it is absolutely impossible to guess what this > > commit is all about without looking at the diff. > > >From the Committers Guide: > "Do not waste space in the commit messages explaining what you did. > That is what cvs diff is for. Instead, tell us why you did it." I think the above needs to be amended to have the intentions made clear. How you did is not important. What you did is. Perhaps the following is a better guide: "Do not waste space in the commit messages explaining how you accomplished what you did. That is what cvs diff is for. Instead, tell us what you did and why." For example: change the buffers schemes to be more efficient. Instead of: pander to the speed freaks. I will submit the above patch tomorrow. -- Dan Langille The FreeBSD Diary - http://freebsddiary.org/ - practical examples To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C03C9FB.9843.13B7AD51>