Date: Mon, 27 Oct 2008 20:40:08 +0100 From: Ed Schouten <ed@80386.nl> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r184300 - in stable/7/lib: libc/stdlib libutil Message-ID: <20081027194008.GO6808@hoeg.nl> In-Reply-To: <200810271422.06751.jhb@freebsd.org> References: <200810262155.m9QLtJG5096815@svn.freebsd.org> <200810271422.06751.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] * John Baldwin <jhb@freebsd.org> wrote: > I would perhaps add a note that the duplicate revoke() in openpty() is only to > support legacy libc's with broken unlockpt() routines. We could maybe remove > the revoke()/ptsname() from openpty() on 8.x though as all 8.x machines > should have a working unlockpt(). Good point, but I'd rather leave revoke() there for at least a couple of months. If people just download the openpty() source from -CURRENT through cvsweb and use it as an example for their own application, they could create a potential security issue when they run the application on RELENG_*. Shall we leave the revoke() call there for now, but remove it before we ship 8.0-RELEASE? -- Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkkGGRgACgkQ52SDGA2eCwXGkACdEjdPDta9QAgbe/GalVoXQNkd GagAnAi/vQe5+IqpOAIWh9rkrmv9T81p =VVa+ -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081027194008.GO6808>