Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Apr 2019 16:43:32 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Ed Maste <emaste@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r346318 - head/lib/libcasper/services/cap_fileargs
Message-ID:  <20190417164331.GA14717@FreeBSD.org>
In-Reply-To: <201904171631.x3HGVUX1066700@repo.freebsd.org>
References:  <201904171631.x3HGVUX1066700@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 17, 2019 at 04:31:30PM +0000, Ed Maste wrote:
> New Revision: 346318
> URL: https://svnweb.freebsd.org/changeset/base/346318
> 
> Log:
>   cap_fileargs: fix GCC build, don't shadow 'stat'
>   
> @@ -566,7 +566,7 @@ static int
>  fileargs_command_lstat(const nvlist_t *limits, nvlist_t *nvlin,
>      nvlist_t *nvlout)
>  {
> -	int stat;
> +	int error;
>  	const char *name;
>  	struct stat sb;
>  
> @@ -578,7 +578,7 @@ fileargs_command_lstat(const nvlist_t *limits, nvlist_
>  
>  	name = nvlist_get_string(nvlin, "name");
>  
> -	stat = lstat(name, &sb);
> +	error = lstat(name, &sb);
>  	if (stat < 0)
>  		return (errno);

Looks like "if (stat < 0)" is wrong now.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190417164331.GA14717>