Date: Tue, 22 Jan 2008 22:51:09 +0100 From: Henrik Brix Andersen <brix@FreeBSD.org> To: Rong-En Fan <rafan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in Message-ID: <20080122215109.GD21985@tirith.brixandersen.dk> In-Reply-To: <20080122015108.GX4650@svm.csie.ntu.edu.tw> References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> <4795044E.6030006@FreeBSD.org> <20080122015108.GX4650@svm.csie.ntu.edu.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
--wxDdMuZNg1r63Hyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 22, 2008 at 09:51:08AM +0800, Rong-En Fan wrote: > On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote: > > The script looks good, thanks for doing this! The only thing I would po= int=20 > > out is that the default _enable=3Dno is not needed, since rc.subr needs= to=20 > > see one of the values for "yes" in order to do anything. No harm leavin= g it=20 > > in, I just wanted to point out that it's not strictly necessary. >=20 > Thanks. I see most of our /etc/rc.d/* scripts does not have this. > But most ports' have as our Porter's Handbook have such example. I believe this is actually required for rc scripts supplied by ports. Scripts included in the base wont need it, since their default settings are already present in /etc/defaults/rc.conf. I just tried removing the default setting for '$bitlbee_enable' in the rc script for irc/bitlbee, I did recently. It then results in the following error when '$bitlbee_enable' is undefined: # /usr/local/etc/rc.d/bitlbee rcvar # bitlbee /usr/local/etc/rc.d/bitlbee: WARNING: $bitlbee_enable is not set properly -= see rc.conf(5). bitlbee_enable=3DNO Brix --=20 Henrik Brix Andersen <brix@FreeBSD.org> --wxDdMuZNg1r63Hyj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFHlmVMv+Q4flTiePgRAh7LAJ42Gp7sq66m387A0nxtpbi69Gnw0QCdH8m7 ZMhxwNceMgcSDQChMIMR8wo= =nef6 -----END PGP SIGNATURE----- --wxDdMuZNg1r63Hyj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080122215109.GD21985>