Date: Thu, 6 Jan 2000 15:05:21 +0100 (CET) From: Nick Hibma <n_hibma@webweaving.org> To: Bill Paul <wpaul@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb if_kue.c Message-ID: <Pine.BSF.4.20.0001061503370.2976-100000@localhost> In-Reply-To: <200001051713.JAA10845@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Does the device reset after the firmware has been loaded? Reset as in reattach to the bus. If it does, you should split the driver in two, with one part the firmware uploader and the second part the driver for the firmware. Nick On Wed, 5 Jan 2000, Bill Paul wrote: > wpaul 2000/01/05 09:13:51 PST > > Modified files: > sys/dev/usb if_kue.c > Log: > Do not attempt to load the firmware a second time. If you reboot your > machine but leave your KLSI adapter plugged into your USB port, it > may stay powered on and retain its firmware in memory. Trying to load > the firmware again in this case will wedge the chip. Try to detect this > in the kue_load_fw() routine and bail if the firmware is already > loaded and running. > > Also, in the probe/match routine, force the revision code to the > hardware default and force a rescan of the quirk database. This is > necessary because the adapter will return a different revision code > if the firmware has been loaded. Without the firmware, the revision > code is 0x002. With the firmware, the revision code is 0x202. This > confuses the quirk mechanism, which won't match a quirk to a device > unless the revision code agrees with the quirk table entry. > > This makes probe/attach of these devices somewhat more reliable. > > Also add a few comments about the device's operation. > > Revision Changes Path > 1.2 +59 -1 src/sys/dev/usb/if_kue.c > > > -- n_hibma@webweaving.org n_hibma@freebsd.org USB project http://www.etla.net/~n_hibma/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.20.0001061503370.2976-100000>