Date: Tue, 9 Jul 2013 08:30:49 +0200 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, Bryan Drewery <bdrewery@freebsd.org>, ports-committers@freebsd.org, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r322444 - head/Tools/scripts Message-ID: <CAF6rxgmBu3qS5sZG4d2NQ4B2VyA1cgeQucmF7vXOzN8shG4BWw@mail.gmail.com> In-Reply-To: <20130709062239.GA76101@FreeBSD.org> References: <201307071532.r67FWZTH036372@svn.freebsd.org> <51D98A76.7090505@FreeBSD.org> <CAF6rxg=UWEC%2Bsn6SU4-7nipODxK83LQteQi-3F6a9dr-DM3yeA@mail.gmail.com> <51DB0777.8080300@FreeBSD.org> <CAF6rxgkE4bJ%2Bz3miKkDUrJqCgtetgJFX=qHv4M6=M7D9mKbuXQ@mail.gmail.com> <08cbb4c709544cad3671c093558910bb@mail.adamw.org> <51DB2DB9.1070104@FreeBSD.org> <20130709011838.GA7501@FreeBSD.org> <CAF6rxgmnuUxAoXGk4Qs48trbsQh8w76aaAL71VokurgL_f0CZA@mail.gmail.com> <20130709062239.GA76101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 9, 2013 at 8:22 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Jul 09, 2013 at 08:06:36AM +0200, Eitan Adler wrote: >> On Tue, Jul 9, 2013 at 3:18 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > So is d4p port itself. Why not just bundle it there? Mk/ is not really >> > for helper shell scripts, even critical ones. >> >> Why not? > > 1) Because Mk/ is for make(1) code, while this is a shell script? Dividing code based on language seems silly to me. > 2) It looks more like some part of d4p, rather than some part of b.p.m. So then it should be distributed with d4p. In any case this script is critical for interacting with the ports tree. ... I don't really care where this script ends up. I thought it would be better to have in a place which didn't seem to indicate "this is a third party helper script" but if the bikeshed is going to take more than 1 person to paint lets just drop it. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmBu3qS5sZG4d2NQ4B2VyA1cgeQucmF7vXOzN8shG4BWw>