Date: Mon, 31 Mar 2003 22:03:37 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c Message-ID: <20030331.220337.54443711.imp@bsdimp.com> In-Reply-To: <Pine.BSF.4.21.0303311628380.8123-100000@root.org> References: <20030331141312.A27442@grasshopper.cs.duke.edu> <Pine.BSF.4.21.0303311628380.8123-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <Pine.BSF.4.21.0303311628380.8123-100000@root.org>
Nate Lawson <nate@root.org> writes:
: On Mon, 31 Mar 2003, Andrew Gallatin wrote:
: > Nate Lawson [nate@root.org] wrote:
: > > On Mon, 31 Mar 2003, Nate Lawson wrote:
: > > > Modified files:
: > > > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c
: > > > if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c
: > > > if_wb.c if_xl.c
: > > > Log:
: > > > Clean up locking and resource management for pci/if_*
: > >
: > > This is a rather large patch so if you begin to experience problems
: > > attaching or detaching (say on module load/unload) a previously-working
: > > card, please let me know.
: >
: > Very nice.
: >
: > Now that the locking is right, do you plan to enable INTR_MPSAFE on
: > these?
:
: The locking is only right on attach. There is still more locking work to
: be done on the data path.
Many of the drivers get the locking almost right, but there may still
be issues with the watchdog timeout routines and lock ordering...
That's the only corner of most of these drivers that I've seen major
locking problems in...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030331.220337.54443711.imp>