Date: Tue, 13 Dec 2011 09:00:50 +0100 From: Stefan Bethke <stb@lassitu.de> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-embedded@freebsd.org Subject: Re: TL-WR1043: switch Message-ID: <55D569DB-875B-412B-8650-C56F85D8E327@lassitu.de> In-Reply-To: <CAJ-VmokdvgPC5gXy9n6KFxYwvLLZCtVL%2B_Y-JN5VuH=8CCroVQ@mail.gmail.com> References: <68ABED76-CB1F-405A-8036-EC254F7511FA@lassitu.de> <3B3DB17D-BF87-40EE-B1C1-445F178E8844@lassitu.de> <86030CEE-6839-4B96-ACDC-2BA9AC1E4AE4@lassitu.de> <2D625CC9-A0E3-47AA-A504-CE8FB2F90245@lassitu.de> <203BF1C8-D528-40C9-8611-9C7AC7E43BAB@lassitu.de> <3C0E9CA3-E130-4E9A-ABCC-1782E28999D1@lassitu.de> <CAJ-VmomWsGy9wMb0zA-WjTRP6Qh%2BO2u_Pe-rgkerFFpi04iKnw@mail.gmail.com> <6387ABA5-AC55-49DD-9058-E45CC0A3E0A0@lassitu.de> <CAJ-VmonM91s-kbbEqVDy9PvtH-gxLWYmusGiqzqCWMtfMdoo2A@mail.gmail.com> <EA0807C1-6FEE-4743-8DCA-1AC873664005@lassitu.de> <74E4AF57-3D22-415E-B913-176753B09B16@lassitu.de> <710E2C7A-E9AC-4103-8C61-0EDC4A3AF9DE@lassitu.de> <C2885254-F02C-401B-B56D-39F62933F3CC@lassitu.de> <24FB4633-B729-4582-9FF6-CA8656742985@lassitu.de> <CAJ-VmokdvgPC5gXy9n6KFxYwvLLZCtVL%2B_Y-JN5VuH=8CCroVQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 13.12.2011 um 02:41 schrieb Adrian Chadd: > Hm, it seems your etherswitchcfg code is reusing code from ifconfig? > Or is that code from ray? > > Just a nitpick, we should likely avoid that code duplication and > either roll this into ifconfig, or should we just break out the > ifconfig related code into a shared library and reuse that? Ultimately, that would be the correct way. I'd start working on that once it's clear that this is the way forward. Integrating the switch configuration code into ifconfig has crossed my mind, but I think the overlap is too small to make sense. While the media code manipulates the same data structures (struct ifreq, struct ifmediareq), the ioctls are completely different, so much of the ifconfig infrastructure is actually in the way. I'm using sbin/ifconfig/if_media.c unchanged except for exporting some of the low level functions for printing and parsing media and mediaopt. I'm not certain where this code would go to be shared efficiently. Also, wherever it goes ifconfig still needs to be buildable for /rescue. Stefan -- Stefan Bethke <stb@lassitu.de> Fon +49 151 14070811
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55D569DB-875B-412B-8650-C56F85D8E327>