Date: Fri, 28 Oct 2022 11:00:31 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 8e9a651acbe5 - main - hyperv: Don't build on 32-bit arm Message-ID: <CANCZdfrBPRT5qV1qy3k=p-0jMZgD2VhRz4cfut8t5GOqbYoOEg@mail.gmail.com> In-Reply-To: <58c8b7f5-3aba-96fa-5bc0-72dda9f0e812@FreeBSD.org> References: <202210271922.29RJM7N0045526@gitrepo.freebsd.org> <58c8b7f5-3aba-96fa-5bc0-72dda9f0e812@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Oct 28, 2022, 9:59 AM John Baldwin <jhb@freebsd.org> wrote: > On 10/27/22 12:22 PM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=8e9a651acbe523f03b22d9c19c0315f686eb14d6 > > > > commit 8e9a651acbe523f03b22d9c19c0315f686eb14d6 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-10-27 19:18:52 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-10-27 19:18:52 +0000 > > > > hyperv: Don't build on 32-bit arm > > > > Sponsored by: Netflix > > --- > > sys/modules/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > > index 5d6f8a352a86..d7aa34ca7611 100644 > > --- a/sys/modules/Makefile > > +++ b/sys/modules/Makefile > > @@ -659,6 +659,8 @@ _sdhci_fdt= sdhci_fdt > > .endif > > _e6000sw= e6000sw > > _neta= neta > > +.endif > > +.if ${MACHINE_CPUARCH} == "aarch64" > > _hyperv= hyperv > > .endif > > Hmm, maybe move it up to the existing aarch64-only section above this? > Sure. I just did this fast after I committed something and got the ci mail Warner > -- > John Baldwin > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 28, 2022, 9:59 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 10/27/22 12:22 PM, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=8e9a651acbe523f03b22d9c19c0315f686eb14d6" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=8e9a651acbe523f03b22d9c19c0315f686eb14d6</a><br> > <br> > commit 8e9a651acbe523f03b22d9c19c0315f686eb14d6<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2022-10-27 19:18:52 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2022-10-27 19:18:52 +0000<br> > <br> > hyperv: Don't build on 32-bit arm<br> > <br> > Sponsored by: Netflix<br> > ---<br> > sys/modules/Makefile | 2 ++<br> > 1 file changed, 2 insertions(+)<br> > <br> > diff --git a/sys/modules/Makefile b/sys/modules/Makefile<br> > index 5d6f8a352a86..d7aa34ca7611 100644<br> > --- a/sys/modules/Makefile<br> > +++ b/sys/modules/Makefile<br> > @@ -659,6 +659,8 @@ _sdhci_fdt= sdhci_fdt<br> > .endif<br> > _e6000sw= e6000sw<br> > _neta= neta<br> > +.endif<br> > +.if ${MACHINE_CPUARCH} == "aarch64"<br> > _hyperv= hyperv<br> > .endif<br> <br> Hmm, maybe move it up to the existing aarch64-only section above this?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">Sure. I just did this fast after I committed something and got the ci mail</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -- <br> John Baldwin<br> <br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrBPRT5qV1qy3k=p-0jMZgD2VhRz4cfut8t5GOqbYoOEg>
