Date: Sun, 22 Mar 2015 23:19:20 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, freebsd-current Current <freebsd-current@freebsd.org>, "jenkins-admin@freebsd.org" <jenkins-admin@freebsd.org>, freebsd-toolchain@freebsd.org Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Message-ID: <DBF10609-2251-417D-B45B-64C38F7A27C3@FreeBSD.org> In-Reply-To: <FA0D53E2-8298-44C9-9C40-B97D17E3A7BB@gmail.com> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <CAG=rPVeyamLPnC5i05_=Ub0D%2BV256U_8t8R5tfDitC=NkjBOFQ@mail.gmail.com> <BE5A3694-E1D1-4A47-8707-D6214E997363@FreeBSD.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <CAG=rPVchdm_VaTshq%2BRN%2BkHX0YC0_Tsx22oJVNNnoOamdm00mQ@mail.gmail.com> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> <CAG=rPVdP_TAmerKh_82EravEw=sCj4LyEBu-NfGCK0Obg=HMVw@mail.gmail.com> <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> <FA0D53E2-8298-44C9-9C40-B97D17E3A7BB@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 22 Mar 2015, at 23:11, Garrett Cooper <yaneurabeya@gmail.com> wrote: > > On Mar 22, 2015, at 15:09, Dimitry Andric <dim@FreeBSD.org> wrote: > >> On 22 Mar 2015, at 23:04, Garrett Cooper <yaneurabeya@gmail.com> wrote: >>> >>> On Mar 22, 2015, at 15:01, Craig Rodrigues <rodrigc@FreeBSD.org> wrote: >>> >>> ... >>> >>>> OK, converting expr.y to use unsigned integers would require a bit of work. >>>> >>>> Can you commit your patch to the Makefile? It fixes the problem for now. >>> >>> +1 >>> >>> I’d still like to know why clang 3.5 doesn’t have this behavior though — there might be other potential issues lurking around that need to be solved (either here, in ports, or both). >> >> Because this version optimizes better around undefined behavior. There >> are most likely many issues lurking around, and most certainly in ports. >> >> I would recommend using UBSan to tackle this kind of thing. > > I hope this got a ports tinderbox run first… It is called an "exp-run" in ports land, but that only really tests whether ports *build* successfully. For most ports, there is no good way of testing them, certainly not if they don't have their own testing facilities. That said, I have built quite a number of ports with 3.6.0, even before the import, and saw zero problems until now. Then again, I'm just one user, and that is a very low sample size. ;) I don't expect a great many problems with integer wrapping though. You have to realize that quite a lot of open source projects already went through this phase, when gcc started optimizing integer wrapping a few years ago. We are just slowly catching up. > Adding UBSan to tinderbox runs for toolchain upgrades [in the future] might be a good idea. Maybe, but please note that both ASan and UBSan are still beta-ish under FreeBSD, there will most likely be bumps along the road. Any bug reports in that area are welcome. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPP+gACgkQsF6jCi4glqNNQgCdEyuU258imuu7h+koQkg2q/B0 SWEAmwaAd9VLhiRiz2+5Th9OyPxyxlGO =lsge -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DBF10609-2251-417D-B45B-64C38F7A27C3>