Date: Tue, 11 Nov 2003 18:44:21 -0800 (PST) From: Peter Wemm <peter@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 42073 for review Message-ID: <200311120244.hAC2iLb3027692@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=42073 Change 42073 by peter@peter_daintree on 2003/11/11 18:43:20 clean up a leftover merge turd. Add note about moving the EOI and masking into C, along with the curthread->td_intr_nesting_level++; frobbing etc. Affected files ... .. //depot/projects/hammer/sys/amd64/isa/atpic_vector.S#2 edit Differences ... ==== //depot/projects/hammer/sys/amd64/isa/atpic_vector.S#2 (text+ko) ==== @@ -58,15 +58,6 @@ outb %al,$IO_ICU2 ; /* but do second icu first ... */ \ outb %al,$IO_ICU1 /* ... then first icu */ - -#define PUSH_FRAME \ - -#define MASK_IRQ(icu, irq_num) \ - movb imen + IRQ_BYTE(irq_num),%al ; \ - orb $IRQ_BIT(irq_num),%al ; \ - movb %al,imen + IRQ_BYTE(irq_num) ; \ - outb %al,$icu+ICU_IMR_OFFSET - /* * Macros for interrupt interrupt entry, call to handler, and exit. * @@ -75,6 +66,7 @@ * XXX we really shouldn't return via doreti if we just schedule the * interrupt handler and don't run anything. We could just do an * iret. FIXME. + * XXX move the mask, EOI and td_intr_nesting_level frobbing into C code. */ #define INTR(irq_num, vec_name, icu, enable_icus, maybe_extra_ipending) \ .text ; \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311120244.hAC2iLb3027692>