Date: Fri, 28 Oct 2022 12:12:55 -0600 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: ba9f71ddeca8 - main - sys/modules: simplify a little by moving syscons to x86 only Message-ID: <CANCZdfodkZmLGuV0kCL7cU12dKVe=ZJJA-U_LRynk%2B-y=Q7B0A@mail.gmail.com> In-Reply-To: <CBAC32CF-40FD-4714-BD89-2E1B2E680557@freebsd.org> References: <202210281753.29SHrut7052860@gitrepo.freebsd.org> <CBAC32CF-40FD-4714-BD89-2E1B2E680557@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Oct 28, 2022, 11:57 AM Jessica Clarke <jrtc27@freebsd.org> wrote: > On 28 Oct 2022, at 18:53, Warner Losh <imp@FreeBSD.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=ba9f71ddeca84404e318b86078c91620f3d6375d > > > > commit ba9f71ddeca84404e318b86078c91620f3d6375d > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-10-28 17:51:02 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-10-28 17:52:40 +0000 > > > > sys/modules: simplify a little by moving syscons to x86 only > > > > syscons is x86 only now that sparc has been retired. No need for the > > extra if. Also alphabetize p2sb. > > > > Sponsored by: Netflix > > --- > > sys/modules/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > > index 9784473fc522..1b03d41b5bd8 100644 > > --- a/sys/modules/Makefile > > +++ b/sys/modules/Makefile > > @@ -632,7 +632,6 @@ SUBDIR+= zfs > > > > .if ${MACHINE_CPUARCH} != "aarch64" && ${MACHINE_CPUARCH} != "arm" && \ > > ${MACHINE_CPUARCH} != "powerpc" && ${MACHINE_CPUARCH} != "riscv" > > -_syscons= syscons > > .endif > > This is now empty? > Doh. Yea. I thought I'd killed that. Will fix :( Warner > Jess > > > .if ${MK_SOURCELESS_UCODE} != "no" > > @@ -693,6 +692,7 @@ _mgb= mgb > > _nctgpio= nctgpio > > _ntb= ntb > > _ocs_fc= ocs_fc > > +_p2sb= p2sb > > _qat= qat > > _qatfw= qatfw > > _qat_c2xxx= qat_c2xxx > > @@ -703,7 +703,7 @@ _rdma= rdma > > _safe= safe > > _speaker= speaker > > _splash= splash > > -_p2sb= p2sb > > +_syscons= syscons > > _wbwd= wbwd > > > > _aac= aac > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 28, 2022, 11:57 AM Jessica Clarke <<a href="mailto:jrtc27@freebsd.org">jrtc27@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 28 Oct 2022, at 18:53, Warner Losh <imp@FreeBSD.org> wrote:<br> > <br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=ba9f71ddeca84404e318b86078c91620f3d6375d" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=ba9f71ddeca84404e318b86078c91620f3d6375d</a><br>; > <br> > commit ba9f71ddeca84404e318b86078c91620f3d6375d<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2022-10-28 17:51:02 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2022-10-28 17:52:40 +0000<br> > <br> > sys/modules: simplify a little by moving syscons to x86 only<br> > <br> > syscons is x86 only now that sparc has been retired. No need for the<br> > extra if. Also alphabetize p2sb.<br> > <br> > Sponsored by: Netflix<br> > ---<br> > sys/modules/Makefile | 4 ++--<br> > 1 file changed, 2 insertions(+), 2 deletions(-)<br> > <br> > diff --git a/sys/modules/Makefile b/sys/modules/Makefile<br> > index 9784473fc522..1b03d41b5bd8 100644<br> > --- a/sys/modules/Makefile<br> > +++ b/sys/modules/Makefile<br> > @@ -632,7 +632,6 @@ SUBDIR+= zfs<br> > <br> > .if ${MACHINE_CPUARCH} != "aarch64" && ${MACHINE_CPUARCH} != "arm" && \<br> > ${MACHINE_CPUARCH} != "powerpc" && ${MACHINE_CPUARCH} != "riscv"<br> > -_syscons= syscons<br> > .endif<br> <br> This is now empty?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">Doh. Yea. I thought I'd killed that. Will fix :(</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Jess<br> <br> > .if ${MK_SOURCELESS_UCODE} != "no"<br> > @@ -693,6 +692,7 @@ _mgb= mgb<br> > _nctgpio= nctgpio<br> > _ntb= ntb<br> > _ocs_fc= ocs_fc<br> > +_p2sb= p2sb<br> > _qat= qat<br> > _qatfw= qatfw<br> > _qat_c2xxx= qat_c2xxx<br> > @@ -703,7 +703,7 @@ _rdma= rdma<br> > _safe= safe<br> > _speaker= speaker<br> > _splash= splash<br> > -_p2sb= p2sb<br> > +_syscons= syscons<br> > _wbwd= wbwd<br> > <br> > _aac= aac<br> <br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfodkZmLGuV0kCL7cU12dKVe=ZJJA-U_LRynk%2B-y=Q7B0A>