Date: Wed, 23 May 2012 16:39:18 +0200 From: Bernhard Froehlich <decke@FreeBSD.org> To: Pav Lucistnik <pav@freebsd.org> Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, Bernhard Froehlich <decke@freebsd.org>, cvs-all@freebsd.org, Martin Wilke <miwi@freebsd.org> Subject: Re: cvs commit: ports/databases/pg_filedump Makefile Message-ID: <a2ac942a73bd4575d797fc7cc250fe31@bluelife.at> In-Reply-To: <1337781346.2024.8.camel@pav.hide.vol.cz> References: <201205231334.q4NDYCMQ078804@repoman.freebsd.org> <1337780396.2024.2.camel@pav.hide.vol.cz> <9b15e44319f017bff90bc3caa1de79d9@bluelife.at> <1337781238.2024.7.camel@pav.hide.vol.cz> <1337781346.2024.8.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23.05.2012 15:55, Pav Lucistnik wrote:
> Pav Lucistnik píše v st 23. 05. 2012 v 15:53 +0200:
>> Bernhard Froehlich píše v st 23. 05. 2012 v 15:47 +0200:
>> > On 23.05.2012 15:39, Pav Lucistnik wrote:
>> > > Martin Wilke píše v st 23. 05. 2012 v 13:34 +0000:
>> > >> miwi 2012-05-23 13:34:12 UTC
>> > >>
>> > >> FreeBSD ports repository
>> > >>
>> > >> Modified files:
>> > >> databases/pg_filedump Makefile
>> > >> Log:
>> > >> - Switch to FETCH_DEPENDS to fix fetch during build
>> > >
>> > > How is this supposed to work? The log message makes no sense.
>> >
>> > The problem that this fixes is when you are building in jails
>> > and restrict internet access to the "fetch" target like
>> > pointyhat-west, redports.org and poudriere already do.
>>
>> Well, the restriction was put in place for a reason 1*), and now
>> you're
>> working around that very reason. So just remove the restriction from
>> pointyhat and problem solved.
>
> On a second read, now I see what you're achieving. But still, the
> chosen
> solution seems suboptimal.
On the list of broken ports there are a handful of ports (including
this
one) that depend on another ports code (aka working directory). Right
now
those ports are written using a dirty hack like that:
from databases/mysql-q4m:
BUILD_DEPENDS=
${NONEXISTENT}:${PORTSDIR}/databases/mysql${MYSQL_VER}-server:build
CONFIGURE_ARGS= --with-mysql="$$(cd
${PORTSDIR}/databases/mysql${MYSQL_VER}-server; ${MAKE} -V WRKSRC)"
We decided to choose the s/BUILD_DEPENDS/FETCH_DEPENDS/ solution
because
it doesn't actually make the hack much worse than it already is. The
downside is that it builds during fetch which isn't nice but better
than
fetch during build which is a security improvement.
If someone comes up with a better solution without completely rewriting
all those ports I would be glad to help doing it. Right now it looks
like
there are around 5-10 ports of that kind.
--
Bernhard Froehlich
http://www.bluelife.at/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a2ac942a73bd4575d797fc7cc250fe31>