Date: Tue, 13 Feb 2018 13:55:47 -0700 From: Warner Losh <imp@bsdimp.com> To: Ravi Pokala <rpokala@mac.com> Cc: Eric van Gyzen <eric@vangyzen.net>, Ed Maste <emaste@freebsd.org>, Ian Lepore <ian@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329237 - head/sys/libkern Message-ID: <CANCZdfr7ErktF-3myc0CgL=dYLqxjrOpXrfGBGiCoo82OXY3HQ@mail.gmail.com> In-Reply-To: <A08C03AF-F642-4591-BA9C-82493D59DCA2@mac.com> References: <201802131917.w1DJHmso047463@repo.freebsd.org> <1518549829.85310.39.camel@freebsd.org> <CAPyFy2Cckiz8iBzy664-%2BpVCPJhmxdD_JmzmEpSo5WFV-b8DEA@mail.gmail.com> <1b3a489d-d62c-6f88-a269-a35ad9bf5ef5@vangyzen.net> <A08C03AF-F642-4591-BA9C-82493D59DCA2@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 13, 2018 at 1:40 PM, Ravi Pokala <rpokala@mac.com> wrote: > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Eric van Gyzen < > eric@vangyzen.net> > Date: 2018-02-13, Tuesday at 11:52 > To: Ed Maste <emaste@freebsd.org>, Ian Lepore <ian@freebsd.org> > Cc: src-committers <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, > <svn-src-head@freebsd.org> > Subject: Re: svn commit: r329237 - head/sys/libkern > > > ... > > > > I prefer '\0' here because it tells the reader that it's a NUL > > character, as opposed to a NULL pointer or a zero integer. Yes, the > > reader should already know that, but the author can /help/ the reader by > > communicating more clearly and completely. > > > > Eric > > Out of morbid curiosity, does any standard (or any of our non-standard > headers) define a "NUL" macro for use as a manual string terminator? > No. There's no standard define. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr7ErktF-3myc0CgL=dYLqxjrOpXrfGBGiCoo82OXY3HQ>