Date: Sat, 5 Oct 1996 01:56:23 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com> To: jkh@time.cdrom.com (Jordan K. Hubbard) Cc: jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-user@freefall.freebsd.org Subject: Re: cvs commit: src/release/sysinstall uc_main.c Message-ID: <199610050856.BAA29691@GndRsh.aac.dev.com> In-Reply-To: <20959.844499267@time.cdrom.com> from "Jordan K. Hubbard" at "Oct 5, 96 00:07:47 am"
next in thread | previous in thread | raw e-mail | index | archive | help
> > 200 lines of changed code should have a lot more of a comment than > > ``Bogon''. Could you PLEASE be more explicit in your commit messages, > > as I have noticed lately that your using this message for just about > > everything :-(. > > I do this when the commit message wouldn't mean anything to anyone but > myself. And that is a very good reason to put discriptive text in there, or perhaps you never use cvs rlog to go find things you have done to a file in the past. > I'm all for descriptive commit messages, generally speaking, > but I'm also not going to waste much time thinking up descriptive text > for an audience of one or two people who are only going to end up > funneling their changes through me anyway. Your ``audience'' is all of the people on the commit mailling list, every single person on that list gets these messages. Also any one in the future who might inherit or start to work on sysinstall is probably going to hate you an awful lot for the quality of what a cvs rlog will tell them about the evolution of the code, what was tried and found not to work so backed out a few commits latter, etc, etc... This _IS_ the major source of evolutionary documentation, and just because you are the only one hacking on that code doesn't mean your hacking can be poorly documented. John and David are probably the only ones who will ever touch the vm system, but look at the commit messages they turn out... > I know that you personally > don't hack sysinstall, never have hacked sysinstall and, in all > likelyhood, ever WILL hack on sysinstall, so what's the beef? :-) See above, just because I don't hack on it don't mean I don't want to know what your are changing and why you are changing it. Who knows, you might get a few ``thanks!!!'' if I knew you just fixed some thing that was driving me nuts (yes, I do use sysinstall, not very often, but I still run into things that make me scratch my head a little and fumble around trying to find out why it won't do what I thought it should do). I would probably fumble a heck of a lot less if your commit messages had informed me that things had changed in certain ways. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610050856.BAA29691>