Date: Wed, 24 Jun 2009 21:09:56 +0000 (UTC) From: Andrew Gallatin <gallatin@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/mxge if_mxge.c if_mxge_var.h Message-ID: <200906242110.n5OLAFkw068270@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
gallatin 2009-06-24 21:09:56 UTC
FreeBSD src repository
Modified files:
sys/dev/mxge if_mxge.c if_mxge_var.h
Log:
SVN rev 194909 on 2009-06-24 21:09:56Z by gallatin
Add a dying flag to prevent races at detach.
I tried re-ordering ether_ifdetach(), but this created a new race
where sometimes, when under heavy receive load (>1Mpps) and running
tcpdump, the machine would panic. At panic, the ithread was still in
the original (not dead) if_input() path, and was accessing stale BPF
data structs. By using a dying flag, I can close the interface prior
to if_detach() to be certain the interface cannot send packets up in
the middle of ether_ifdetach.
Revision Changes Path
1.62 +6 -0 src/sys/dev/mxge/if_mxge.c
1.30 +1 -0 src/sys/dev/mxge/if_mxge_var.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906242110.n5OLAFkw068270>