Date: Wed, 21 Aug 2002 19:18:47 -0400 From: cd9@buffalo.edu To: FreeBSD-gnats-submit@FreeBSD.org Cc: cd9@buffalo.edu Subject: bin/41870: [PATCH] atacontrol reports SMART settings for "security" Message-ID: <20020821191847.A87558@selvirjin.alltel.net>
next in thread | raw e-mail | index | archive | help
>Number: 41870
>Category: bin
>Synopsis: [PATCH] atacontrol reports SMART settings for "security"
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Aug 21 16:20:06 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: C. A. Daelhousen
>Release: FreeBSD 4.6-STABLE i386
>Organization:
>Environment:
System: FreeBSD selvirjin.alltel.net 4.6-STABLE FreeBSD 4.6-STABLE #2:
Wed Aug 21 13:21:57 EDT 2002
root@selvirjin.alltel.net:/usr/obj/usr/src/sys/V8 i386
>Description:
In /usr/src/sbin/atacontrol/atacontrol.c v1.11.2.5, function
cap_print, line 161:
For "security", the printf statement uses the values of
parm->support.smart and parm->enabled.smart rather than
parm->support.security and parm->enabled.security.
>How-To-Repeat:
Unknown--the problem was spotted while reading source.
Presumably, running "atacontrol cap" on a device that has either SMART
or security (but not both) enabled or supported would show the bug.
>Fix:
Caveat: I'm a novice at operating diff. Check the headers before
use. Times are UTC -0400.
Patch against src/sbin/atacontrol/atacontrol.c,v 1.11.2.5:
--- src/sbin/atacontrol/atacontrol.c Wed Aug 21 11:24:21 2002
+++ src/sbin/atacontrol/atacontrol-patched.c Wed Aug 21 15:15:04 2002
@@ -158,8 +158,8 @@
parm->enabled.microcode ? "yes" : "no");
printf("security %s %s\n",
- parm->support.smart ? "yes" : "no",
- parm->enabled.smart ? "yes" : "no");
+ parm->support.security ? "yes" : "no",
+ parm->enabled.security ? "yes" : "no");
printf("power management %s %s\n",
parm->support.power_mngt ? "yes" : "no",
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020821191847.A87558>