Date: Fri, 10 Jan 2020 09:21:51 +0000 From: <Shichun.Ma@dell.com> To: <hps@selasky.org>, <freebsd-usb@freebsd.org> Cc: <Shunchao.Hu@dell.com> Subject: Re: minor improve for xhci_cmd_stop_ep in xhci_configure_reset_endpoint Message-ID: <1578648110788.20024@Dell.com> In-Reply-To: <e946ecd2-0da5-6b5f-75e8-a7ad6ccbdf00@selasky.org> References: <1578623361805.72194@Dell.com> <e91118b0-7efa-bf9d-3463-5dbf18d177d7@selasky.org>, <e946ecd2-0da5-6b5f-75e8-a7ad6ccbdf00@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi HPS,=0A= XHCI spec mentioned this, =0A= https://www.intel.com/content/dam/www/public/us/en/documents/technical-spec= ifications/extensible-host-controler-interface-usb-xhci.pdf, P443=0A= =0A= The Device Context data structure is used in the xHCI architecture as Outpu= t by the xHC to report device configuration and state information to system= software. The Device Context data structure is pointed to by an entry in t= he Device Context Base Address Array (refer to sectio=0A= =0A= XHCI shoud update this memory.=0A= =0A= your diff is ok in my test.=0A= =0A= Thanks & Regards,=0A= =0A= Shichun Ma=0A= Software Engineer=0A= Dell | Cloud Client Computing=0A= office +86 10 82862579, Mobile +86 13241851528=0A= shichun_ma@dell.com=0A= =0A= =0A= =0A= ________________________________________=0A= From: Hans Petter Selasky <hps@selasky.org>=0A= Sent: Friday, January 10, 2020 5:02 PM=0A= To: Ma, Horse; freebsd-usb@freebsd.org=0A= Cc: Hu, Shunchao=0A= Subject: Re: minor improve for xhci_cmd_stop_ep in xhci_configure_reset_end= point=0A= =0A= [EXTERNAL EMAIL]=0A= =0A= On 2020-01-10 09:57, Hans Petter Selasky wrote:=0A= > Hi,=0A= >=0A= > Can you test the attached patch?=0A= >=0A= =0A= HI,=0A= =0A= How are we sure that the XHCI doesn't cache the device endpoint state in=0A= its internal memory cache. I.E. that it doesn't update the device=0A= context in host memory at all times?=0A= =0A= I think it is better to query the XHCI controller and if we get an error=0A= back that is OK.=0A= =0A= --HPS=0A= =0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1578648110788.20024>