Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Jun 2024 12:04:40 GMT
From:      Zhenlei Huang <zlei@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 4eb82e65a73f - main - hidbus(4): Fix wrong assertion of bus
Message-ID:  <202406051204.455C4et4098226@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=4eb82e65a73f6cd180700bb8ae47227a553f94ed

commit 4eb82e65a73f6cd180700bb8ae47227a553f94ed
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2024-06-05 12:03:27 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2024-06-05 12:03:27 +0000

    hidbus(4): Fix wrong assertion of bus
    
    Reviewed by:    wulf
    Fixes:          4151ac9f1292 hidbus(4): Use generic hid methods to ...
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D45496
---
 sys/dev/hid/hidbus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/hid/hidbus.c b/sys/dev/hid/hidbus.c
index 99bfd7715c24..f50abd4b0a4d 100644
--- a/sys/dev/hid/hidbus.c
+++ b/sys/dev/hid/hidbus.c
@@ -604,7 +604,7 @@ hidbus_set_intr(device_t child, hid_intr_t *handler, void *context)
 static int
 hidbus_intr_start(device_t bus, device_t child)
 {
-	MPASS(bus = device_get_parent(child));
+	MPASS(bus == device_get_parent(child));
 	struct hidbus_softc *sc = device_get_softc(bus);
 	struct hidbus_ivars *ivar = device_get_ivars(child);
 	struct hidbus_ivars *tlc;
@@ -630,7 +630,7 @@ hidbus_intr_start(device_t bus, device_t child)
 static int
 hidbus_intr_stop(device_t bus, device_t child)
 {
-	MPASS(bus = device_get_parent(child));
+	MPASS(bus == device_get_parent(child));
 	struct hidbus_softc *sc = device_get_softc(bus);
 	struct hidbus_ivars *ivar = device_get_ivars(child);
 	struct hidbus_ivars *tlc;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202406051204.455C4et4098226>