Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jul 2014 10:46:44 -0700
From:      Sean Fagan <sef@ixsystems.com>
To:        Brooks Davis <brooks@freebsd.org>
Cc:        hackers@freebsd.org
Subject:   Re: Expanding on NO_ROOT:  Categorizing installed files
Message-ID:  <B0AABD58-E25C-4514-949E-4A91ED15B3BF@ixsystems.com>
In-Reply-To: <20140716170758.GE60425@spindle.one-eyed-alien.net>
References:  <FE374F8B-ABF7-4497-B1C7-68E63612DC43@ixsystems.com> <20140716170758.GE60425@spindle.one-eyed-alien.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 16, 2014, at 10:07 AM, Brooks Davis <brooks@freebsd.org> wrote:

> The vast majorify of the diff is make debugging garbage that looks =
like
> it was committed by accident.  I won't provided any detailed review
> of the current patch except to say that there are a lot of apparently
> redundent instances of setting META_CATEGORY in Makefiles and still
> quite a lot of instances of .EXPORTVAR: META_CATEGORY.

There were ten.  I've removed those (and the make debug out, and
a stray .orig file, grrr), and am testing now.  That'll take a while ;).

>> I have not changed it from having a new "category=3D" to using =
"tag=3D"; I looked at that, and don't think it's the best way to go, but =
am still looking.
>=20
> Given that the current use of tags=3D is basically unconsumed, I still
> don't understand why.

First, because the space is limited -- it's not "tag type=3Dvalue", but =
"tag=3Dvalue".  So if there is a category of "debug", that conflicts =
with a tag of "debug."  And similarly for any other tags.

Second, because "category=3D" isn't the only keyword I might want to add =
here -- I would prefer that the metalog be considered a key-value =
sequence, and any consumer should simply ignore any key it doesn't =
understand.

(Consider checksums, as a semi-obvious example of one that can be put in =
place by install.)

Combine the two, and I'm very wary of it -- it puts a limitation in, =
when it should be extensible.

Sean.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B0AABD58-E25C-4514-949E-4A91ED15B3BF>