Date: Wed, 30 May 2007 16:18:51 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 120558 for review Message-ID: <20070530141851.GA45778@freebsd.org> In-Reply-To: <200705291445.l4TEjOqo072275@repoman.freebsd.org> References: <200705291445.l4TEjOqo072275@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 29, 2007 at 02:45:24PM +0000, Roman Divacky wrote: > http://perforce.freebsd.org/chv.cgi?CH=120558 > > Change 120558 by rdivacky@rdivacky_witten on 2007/05/29 14:44:59 > > Dont allow zero or negative pid/tid arguments to tgkill/tkill. > > Affected files ... > > .. //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 edit > > Differences ... > > ==== //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 (text+ko) ==== > > @@ -550,8 +550,8 @@ > ka.pid = args->pid; > ka.signum = args->sig; > > - if (args->tgid == -1) > - return linux_kill(td, &ka); > + if (args->pid <= 0 || args->tgid <= 0) > + return EINVAL; this is a WIP and might be wrapped in if (linux_use26(td)), hard to say ;(
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070530141851.GA45778>