Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Mar 2021 12:07:50 GMT
From:      Alex Richardson <arichardson@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6f30d1c85146 - main - ng_macfilter_test: Skip rather than fail if there is no network
Message-ID:  <202103251207.12PC7oVV018809@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=6f30d1c851467d1f504f469a1b3a75a043ff070f

commit 6f30d1c851467d1f504f469a1b3a75a043ff070f
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-03-25 11:14:46 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-25 11:16:12 +0000

    ng_macfilter_test: Skip rather than fail if there is no network
    
    This should bring the number of Jenkins failures from 4 down to 3.
    Locally kyua now prints `skipped: could not find a valid interface  [0.115s]`
    when I run it in QEMU without a network device.
    
    Reviewed By:    lwhsu
    MFC after:      3 days
    Differential Revision: https://reviews.freebsd.org/D29414
---
 tests/sys/netgraph/ng_macfilter_test.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/sys/netgraph/ng_macfilter_test.sh b/tests/sys/netgraph/ng_macfilter_test.sh
index 482f32e5d335..85940e473951 100755
--- a/tests/sys/netgraph/ng_macfilter_test.sh
+++ b/tests/sys/netgraph/ng_macfilter_test.sh
@@ -235,8 +235,7 @@ test_title "Setting up system..."
 load_modules netgraph ng_socket ng_ether ng_macfilter ng_one2many
 eth=$(find_iface)
 if [ -z "$eth" ]; then
-	echo "1..1"
-	echo "not ok 1 - Could not find a valid interface"
+	echo "1..0 # SKIP could not find a valid interface"
 	echo "Available interfaces:"
 	ifconfig
 	exit 1



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103251207.12PC7oVV018809>