Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Jan 2008 22:40:34 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 132436 for review
Message-ID:  <200801032240.m03MeYbJ064934@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=132436

Change 132436 by hselasky@hselasky_laptop001 on 2008/01/03 22:39:52

	
	Small bugfix.
	
	"sc->sc_dci.sc_bus.bdev" will be cleared by "usb_detach",
	so we need to make a copy first and pass that when
	we delete the child.

Affected files ...

.. //depot/projects/usb/src/sys/arm/at91/at91_udp.c#4 edit

Differences ...

==== //depot/projects/usb/src/sys/arm/at91/at91_udp.c#4 (text+ko) ====

@@ -258,12 +258,13 @@
 at91_udp_detach(device_t dev)
 {
 	struct at91_udp_softc *sc = device_get_softc(dev);
+	device_t bdev;
 	int err;
 
 	if (sc->sc_dci.sc_bus.bdev) {
-		device_detach(sc->sc_dci.sc_bus.bdev);
-		device_delete_child(dev, sc->sc_dci.sc_bus.bdev);
-		sc->sc_dci.sc_bus.bdev = NULL;
+		bdev = sc->sc_dci.sc_bus.bdev;
+		device_detach(bdev);
+		device_delete_child(dev, bdev);
 	}
 	/* during module unload there are lots of children leftover */
 	device_delete_all_children(dev);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801032240.m03MeYbJ064934>