Date: Wed, 16 Jul 2014 19:24:10 +0000 From: Brooks Davis <brooks@freebsd.org> To: Sean Fagan <sef@ixsystems.com> Cc: hackers@freebsd.org Subject: Re: Expanding on NO_ROOT: Categorizing installed files Message-ID: <20140716192410.GG60425@spindle.one-eyed-alien.net> In-Reply-To: <B0AABD58-E25C-4514-949E-4A91ED15B3BF@ixsystems.com> References: <FE374F8B-ABF7-4497-B1C7-68E63612DC43@ixsystems.com> <20140716170758.GE60425@spindle.one-eyed-alien.net> <B0AABD58-E25C-4514-949E-4A91ED15B3BF@ixsystems.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jul 16, 2014 at 10:46:44AM -0700, Sean Fagan wrote: > On Jul 16, 2014, at 10:07 AM, Brooks Davis <brooks@freebsd.org> wrote: > >> I have not changed it from having a new "category=" to using "tag="; I looked at that, and don't think it's the best way to go, but am still looking. > > > > Given that the current use of tags= is basically unconsumed, I still > > don't understand why. > > First, because the space is limited -- it's not "tag type=value", but "tag=value". So if there is a category of "debug", that conflicts with a tag of "debug." And similarly for any other tags. > > Second, because "category=" isn't the only keyword I might want to add here -- I would prefer that the metalog be considered a key-value sequence, and any consumer should simply ignore any key it doesn't understand. > > (Consider checksums, as a semi-obvious example of one that can be put in place by install.) > > Combine the two, and I'm very wary of it -- it puts a limitation in, when it should be extensible. You've convinced me. I think the first is a redherring as no one uses the tags, but the second is a good argument. That said, I think the second argues that -P generating category= is the wrong approach. Instead a new flag should just let you add arbitrary stuff to the mtree file (subject to validation that it is well formed). -- Brooks [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlPG0VkACgkQXY6L6fI4GtRY/wCfXWU34b2riK+CrP6PxMON1nE0 FpwAoMRnUIX8OZpSbPJrJ2hW3Ljpbbv7 =t4ZM -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716192410.GG60425>