Date: Tue, 25 Aug 2009 12:26:22 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5 Message-ID: <4A943ADE.2080500@FreeBSD.org> In-Reply-To: <200908251907.n7PJ7QiO036868@svn.freebsd.org> References: <200908251907.n7PJ7QiO036868@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------050907050001070408080904 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit My sincere apologies for missing this the first N times I reviewed it, but both variables in functions should be declared local. Attached is a suggested patch. Doug -- This .signature sanitized for your protection --------------050907050001070408080904 Content-Type: text/plain; name="static_arp-local.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="static_arp-local.diff" SW5kZXg6IHN0YXRpY19hcnAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3RhdGljX2FycAkocmV2aXNp b24gMTk2NTUwKQorKysgc3RhdGljX2FycAkod29ya2luZyBjb3B5KQpAQCAtNDEsMTAgKzQx LDExIEBACiAKIHN0YXRpY19hcnBfc3RhcnQoKQogeworCWxvY2FsIGUgYXJwX2FyZ3MKKwog CWlmIFsgLW4gIiR7c3RhdGljX2FycF9wYWlyc30iIF07IHRoZW4KIAkJZWNobyAtbiAnQmlu ZGluZyBzdGF0aWMgQVJQIHBhaXIocyk6JwogCQlmb3IgZSBpbiAke3N0YXRpY19hcnBfcGFp cnN9OyBkbwotCQkJbG9jYWwgYXJwX2FyZ3MKIAkJCWVjaG8gLW4gIiAke2V9IgogCQkJZXZh bCBhcnBfYXJncz1cJHN0YXRpY19hcnBfJHtlfQogCQkJYXJwIC1TICR7YXJwX2FyZ3N9ID4v ZGV2L251bGwgMj4mMQpAQCAtNTUsMTAgKzU2LDExIEBACiAKIHN0YXRpY19hcnBfc3RvcCgp CiB7CisJbG9jYWwgZSBhcnBfYXJncworCiAJaWYgWyAtbiAiJHtzdGF0aWNfYXJwX3BhaXJz fSIgXTsgdGhlbgogCQllY2hvIC1uICdVbmJpbmRpbmcgc3RhdGljIEFSUCBwYWlyKHMpOicK IAkJZm9yIGUgaW4gJHtzdGF0aWNfYXJwX3BhaXJzfTsgZG8KLQkJCWxvY2FsIGFycF9hcmdz CiAJCQllY2hvIC1uICIgJHtlfSIKIAkJCWV2YWwgYXJwX2FyZ3M9XCRzdGF0aWNfYXJwXyR7 ZX0KIAkJCWFycCAtZCAke2FycF9hcmdzJSVbIAldKn0gPiAvZGV2L251bGwgMj4mMQo= --------------050907050001070408080904--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A943ADE.2080500>