Date: Tue, 25 Aug 2009 12:26:22 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5 Message-ID: <4A943ADE.2080500@FreeBSD.org> In-Reply-To: <200908251907.n7PJ7QiO036868@svn.freebsd.org> References: <200908251907.n7PJ7QiO036868@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
My sincere apologies for missing this the first N times I reviewed it,
but both variables in functions should be declared local. Attached is
a suggested patch.
Doug
--
This .signature sanitized for your protection
[-- Attachment #2 --]
Index: static_arp
===================================================================
--- static_arp (revision 196550)
+++ static_arp (working copy)
@@ -41,10 +41,11 @@
static_arp_start()
{
+ local e arp_args
+
if [ -n "${static_arp_pairs}" ]; then
echo -n 'Binding static ARP pair(s):'
for e in ${static_arp_pairs}; do
- local arp_args
echo -n " ${e}"
eval arp_args=\$static_arp_${e}
arp -S ${arp_args} >/dev/null 2>&1
@@ -55,10 +56,11 @@
static_arp_stop()
{
+ local e arp_args
+
if [ -n "${static_arp_pairs}" ]; then
echo -n 'Unbinding static ARP pair(s):'
for e in ${static_arp_pairs}; do
- local arp_args
echo -n " ${e}"
eval arp_args=\$static_arp_${e}
arp -d ${arp_args%%[ ]*} > /dev/null 2>&1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A943ADE.2080500>