Date: Mon, 04 Jul 2011 00:51:07 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Alex Samorukov <samm@os2.kiev.ua> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org> Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo ports/sysutils/atop/files atop.in pkg-message.in Message-ID: <4E1170EB.2030003@FreeBSD.org> In-Reply-To: <4E105B9B.4060602@os2.kiev.ua> References: <201107021323.p62DNWeP082020@repoman.freebsd.org> <4E0FB8DF.90904@FreeBSD.org> <4E105B9B.4060602@os2.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/03/2011 05:07, Alex Samorukov wrote: > Hello, > > Thank you for comments. > > On 07/03/2011 02:33 AM, Doug Barton wrote: >> Overall this looks good, just 2 small comments. It's not clear why it >> uses: >> >> # REQUIRE: DAEMON >> # BEFORE: LOGIN >> >> Instead of just >> >> # REQUIRE: LOGIN >> >> like most ports scripts do. > Probably my copypaste from some other script. Better to replace with > REQUIRE: LOGIN. > > > Also the default empty assignment for _flags is neither necessary or > desirable. > > Agree. Do i need to submit PR to fix this or you can do it without it? All set, thanks. :) -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E1170EB.2030003>