Date: Sun, 15 Jul 2007 13:12:40 +0200 From: Niclas Zeising <niclas.zeising@gmail.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Dmitry Morozovsky <marck@rinet.ru>, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/mtree BSD.include.dist BSD.usr.dist src/include Makefile src/lib Makefile src/rescue/rescue Makefile src/sbin/atm Makefile src/share/examples Makefile src/sys/conf NOTES files options src/sys/modules Makefile ... Message-ID: <469A0128.6070609@gmail.com> In-Reply-To: <20070715115727.F67691@fledge.watson.org> References: <200707142149.l6ELnOfm059277@repoman.freebsd.org> <20070715103646.I37333@woozle.rinet.ru> <4699E77F.4070509@gmail.com> <20070715115727.F67691@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote: > On Sun, 15 Jul 2007, Niclas Zeising wrote: > >> RW> Disconnect netatm from the build as it is not MPSAFE and relies on >>> RW> NET_NEEDS_GIANT, which will shortly be removed. This is done in a >>> RW> away that it may be easily reattached to the build before 7.1 if >>> RW> appropriate locking is added. Specifics: >>> RW> RW> - Don't install netatm include files >>> RW> - Disconnect netatm command line management tools >>> RW> - Don't build libatm >>> RW> - Don't include ATM parts in rescue or sysinstall >>> RW> - Don't install sample configuration files and documents >>> RW> - Don't build kernel support as a module or in NOTES >>> RW> - Don't build netgraph wrapper nodes for netatm >>> RW> RW> This removes the last remaining consumer of NET_NEEDS_GIANT. >>> >>> Hmm, shouldn't these installation removals be also reflected in >>> ObsoleteFiles? >> >> And src.conf(5)? > > I don't believe the ATM-related options in src.conf(5) (and other spots) > are specific to netatm -- the same ifdefs/ifs/etc are used for netnatm > and the netgraph parts also. If you know of any additional > netatm-specific parts that are still being installed, please let me > know. Right now the only thing I'm aware of that hasn't been removed is > that there are some netatm-related rc.d bits, which I need to > investigate further. I might be entierly wrong. I wasn't aware of there being more than one atm stack as bz@ pointed out. I just thought this was the one implementation and that as it got removed, maybe it should be removed from src.conf(5) as well. If that's not the case, my bad then. Robert, keep up the awesome work! Regards //Niclas --
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?469A0128.6070609>