Date: Thu, 27 Jul 2017 05:31:48 +0000 (UTC) From: Scott Long <scottl@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r321604 - head/usr.sbin/mpsutil Message-ID: <201707270531.v6R5Vmg2095834@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: scottl Date: Thu Jul 27 05:31:48 2017 New Revision: 321604 URL: https://svnweb.freebsd.org/changeset/base/321604 Log: Fix some broken logic used in obtaining the certain config pages. I'm surprised that this even pretended to work. PR: 215793 Submitted by: longwitz@incore.de Modified: head/usr.sbin/mpsutil/mps_cmd.c Modified: head/usr.sbin/mpsutil/mps_cmd.c ============================================================================== --- head/usr.sbin/mpsutil/mps_cmd.c Thu Jul 27 02:53:18 2017 (r321603) +++ head/usr.sbin/mpsutil/mps_cmd.c Thu Jul 27 05:31:48 2017 (r321604) @@ -365,8 +365,7 @@ mps_read_config_page(int fd, U8 PageType, U8 PageNumbe req.Action = MPI2_CONFIG_ACTION_PAGE_READ_CURRENT; req.PageAddress = PageAddress; req.Header = header; - req.Header.PageLength = reply.Header.PageLength; - if (reply.Header.PageLength == 0) + if (req.Header.PageLength == 0) req.Header.PageLength = 4; len = req.Header.PageLength * 4;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707270531.v6R5Vmg2095834>