Date: Thu, 10 Apr 2014 18:19:02 -0400 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: Makefiles for skip-level directories? Message-ID: <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org> In-Reply-To: <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com> References: <16437CC5729B5345AF77F816513376E8129868F1@MX103CL02.corp.emc.com> <CAFY7cWD2A_B949Fp7Pp5rKysNbQE_LqBJh%2BwYD1-v8uGcLEXBw@mail.gmail.com> <16437CC5729B5345AF77F816513376E820BAA20A@MX103CL02.corp.emc.com> <CAFY7cWD52sSES%2BLqFr6T6-=WREF7iF=HGTDuKov4NhJ9_dmxng@mail.gmail.com> <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com> <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 4, 2014, at 19:28, Garrett Cooper <yaneurabeya@gmail.com> wrote: >=20 >> On Apr 4, 2014, at 15:28, "Peel, Casey" <casey.peel@isilon.com> = wrote: >>=20 >> Ok, I figured it out and wrote up the following document (that is = published on our internal wiki). You may take whatever you want of this = for the FreeBSD wiki if you find it useful. >>=20 >> Something rcattelan pointed out while doing the code review for my = gpart changes that I wanted to run past you: >> <daelf> is the include bsd.own.mk to pick up MK_TESTS? >> <cpeel> yes >> <daelf> do you need to do that in the files that are not look at = MK_TESTS? >> <daelf> geom/tests/Makefile ? >> <cpeel> I probably don't have to, but that's how the other Makefiles = like that are done in FreeBSD, eg: src/bin/tests/Makefile >> <daelf> bsd.own.mk is included by bsd.init.mk which is included by = bsd.test.mk=20 >> <daelf> so it seems redundant >> <daelf> maybe we should ask the upstream if is correct ... might be = better to leave it off vs perpetuating something that might not be = right >=20 > Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit = on the cache, and increase the file sizes a small amount. >=20 > In the event that the Makefile snippet would be removed from the = included makefiles then stuff would break horribly. Plus it makes it = clear that MK_TESTS is obtained from bsd.own.mk. bsd.own.mk is not redundant if you are going to test for MK_TESTS; you = need that include. What I=92m not clear about is if bsd.own.mk ought to be bsd.init.mk or = not.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2BC2387E-387B-46EC-832F-78ECEA51A206>