Date: Mon, 7 Apr 2008 11:33:56 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: d@delphij.net Cc: delphij@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [src] cvs commit: src/sys/ufs/ufs ufs_gjournal.c Message-ID: <970636D8-F789-44EE-864D-49489D17D7D9@mac.com> In-Reply-To: <47FA6833.8080904@delphij.net> References: <20080407181250.6733810656C9@hub.freebsd.org> <47FA6833.8080904@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 7, 2008, at 11:30 AM, LI Xin wrote:
> Picking a random commit:
>
>> Index: src/sys/ufs/ufs/ufs_gjournal.c
>> diff -u src/sys/ufs/ufs/ufs_gjournal.c:1.2 src/sys/ufs/ufs/
>> ufs_gjournal.c:1.3
>> --- src/sys/ufs/ufs/ufs_gjournal.c:1.2 Mon May 28 00:28:15 2007
>> +++ src/sys/ufs/ufs/ufs_gjournal.c Mon Apr 7 18:12:37 2008
>> @@ -82,7 +82,7 @@
>> cgbno = fsbtodb(fs, cgtod(fs, cg));
>> }
>> if ((u_int)ino >= fs->fs_ipg * fs->fs_ncg)
>> - panic("ffs_freefile: range: dev = %s, ino = %lu, fs = %s",
>> + panic("ufs_gjournal_modref: range: dev = %s, ino = %lu, fs = %s",
>> devtoname(dev), (u_long)ino, fs->fs_fsmnt);
>> if ((error = bread(devvp, cgbno, (int)fs->fs_cgsize, NOCRED,
>> &bp))) {
>> brelse(bp);
>
> Is it suitable to use something like __func__ here? I mean, will
> the usage of __func__ encouraged practice for base/kernel code or not?
Speaking only for myself: yes, __func__ should be used at all times
when the
function name is needed...
--
Marcel Moolenaar
xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?970636D8-F789-44EE-864D-49489D17D7D9>