Date: Thu, 26 Mar 2009 15:09:23 -0700 (PDT) From: Doug Ambrisko <ambrisko@ambrisko.com> To: John Baldwin <jhb@freebsd.org> Cc: Doug Ambrisko <ambrisko@freebsd.org>, src-committers@freebsd.org, Doug Ambrisko <ambrisko@ambrisko.com>, Roman Divacky <rdivacky@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r190445 - in head/sys: amd64/linux32 compat/linprocfs compat/linux conf dev/ipmi modules/ipmi modules/linprocfs Message-ID: <200903262209.n2QM9NdZ078655@ambrisko.com> In-Reply-To: <200903261758.28547.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin writes: | On Thursday 26 March 2009 5:29:42 pm Doug Ambrisko wrote: [snip] | > Maybe you have another suggestion to fix this. The problem showed up | > when doing a mmap of 0xcf79c000 into 0xffffffffcf79c000 also a mmap | > of 0xf0000 ended up the same way. This caused it to fail. Note this | > is only on amd64 with a Linux. It didn't happen with a FreeBSD i386 | > version on amd64. Here is a sample test program: | | I'm sure this can be easily fixed in the Linux mmap() handlers instead. Do | you know if your Linux binary is using mmap2() or the old mmap()? I think it uses linux_mmap then bouncing it to linux_mmap_common. linux_mmap_common had it right but when it mmap picked it up then it was wrong in my intrumentation. I'll flip the l_off_t type back and then instrument it more to find out when things are going bad. I missed the other usage of l_off_t so I agree this is a bad change. However, I wonder if the other usage of l_off_t actually works right or there is a bug with that as well? I should be able to get something put together pretty quick and send it for review. Thanks, Doug A.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903262209.n2QM9NdZ078655>