Date: Sat, 09 Feb 2013 10:28:12 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Andriy Gapon <avg@FreeBSD.org> Cc: Kirk McKusick <mckusick@mckusick.com>, freebsd-arch@FreeBSD.org Subject: Re: Proposal: Unify printing the function name in panic messages() Message-ID: <511616AC.8080306@gmx.de> In-Reply-To: <5116121E.1010601@FreeBSD.org> References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org> <51160E06.1070404@gmx.de> <5116121E.1010601@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09.02.2013 10:08, Andriy Gapon wrote: > In any case, you just search the code for the message and that's it. Often the messages contains parameters (%d, %s, ...) or are split into multiple lines to appease the ancient 80 columns god. These make it harder to grep. Having the /right/ name makes it easier to get to the right place. > If this is a solution in search of a problem, then I don't like it, because it The two problems this change solves are very simple: - There are needlessly about a dozen different ways used to add the function name into the panic message. This change unifies it. - All too often the name is wrong. This change gets it right every time without any manual and error-prone effort of somebody, who adds a use of PANIC(). > requires massive, if mostly mechanical, changes throughout the code. I do not understand, what the problem is. There are bugs and cumbersome code. This simple changes solves it. Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511616AC.8080306>