Date: Mon, 8 Jun 2009 10:17:53 -0400 From: John Baldwin <jhb@freebsd.org> To: Jaakko Heinonen <jh@saunalahti.fi> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Paul Saab <ps@freebsd.org> Subject: Re: svn commit: r193440 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs kern sys Message-ID: <200906081017.54171.jhb@freebsd.org> In-Reply-To: <20090606090141.GA805@a91-153-125-115.elisa-laajakaista.fi> References: <200906041618.n54GI851097005@svn.freebsd.org> <20090606090141.GA805@a91-153-125-115.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 06 June 2009 5:01:41 am Jaakko Heinonen wrote:
>
> Hi,
>
> On 2009-06-04, Paul Saab wrote:
> > Support shared vnode locks for write operations when the offset is
> > provided on filesystems that support it. This really improves mysql
> > + innodb performance on ZFS.
>
> The panic below looks related to this commit. I think the assert is only
> enabled when DEBUG_VFS_LOCKS is defined.
Yes, vnode_if.src needs to be changed:
%% write vp E E E
%! write pre VOP_WRITE_PRE
%! write post VOP_WRITE_POST
vop_write {
IN struct vnode *vp;
INOUT struct uio *uio;
IN int ioflag;
IN struct ucred *cred;
};
The 'E E E' should be 'L L L'.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906081017.54171.jhb>