Date: Tue, 12 Jun 2012 23:36:43 -0700 From: Doug Barton <dougb@FreeBSD.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/nginx Makefile ports/www/nginx/files nginx.sh.in ports/www/nginx-devel Makefile ports/www/nginx-devel/files nginx.sh.in Message-ID: <4FD834FB.7050705@FreeBSD.org> In-Reply-To: <201206130446.q5D4kEb3031676@repoman.freebsd.org> References: <201206130446.q5D4kEb3031676@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Since it's only called in one place, there's no need to put the
directory code in a function. Also, instead of doing it in 3 steps you
can unconditionally use install as follows:
install -d -o %%WWWOWN%% -g %%WWWGRP%% -m 755 ${_tmpprefix}
hth,
Doug
On 06/12/2012 21:46, Sergey A. Osokin wrote:
> osa 2012-06-13 04:46:14 UTC
>
> FreeBSD ports repository
>
> Modified files:
> www/nginx Makefile
> www/nginx/files nginx.sh.in
> www/nginx-devel Makefile
> www/nginx-devel/files nginx.sh.in
> Log:
> Check existence temporary directory %%NGINX_TMPDIR%% before
> test configuration. (1)
> Use %%NGINX_RUNDIR%%, %%WWWOWN%% and %%WWWGRP%% variables defined
> in Makefile instead of hardcoded or new values.
>
> Bump PORTREVISION.
>
> Idea from PR: 168836 (1)
>
> Revision Changes Path
> 1.464 +5 -1 ports/www/nginx-devel/Makefile
> 1.14 +15 -3 ports/www/nginx-devel/files/nginx.sh.in
> 1.337 +5 -1 ports/www/nginx/Makefile
> 1.12 +15 -3 ports/www/nginx/files/nginx.sh.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx-devel/Makefile.diff?&r1=1.463&r2=1.464&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx-devel/files/nginx.sh.in.diff?&r1=1.13&r2=1.14&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx/Makefile.diff?&r1=1.336&r2=1.337&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx/files/nginx.sh.in.diff?&r1=1.11&r2=1.12&f=u
>
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FD834FB.7050705>