Date: Thu, 25 Dec 2008 14:57:06 +0000 (UTC) From: "Philip M. Gollucci" <pgollucci@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/devel/scons Makefile ports/devel/scons/files patch-engine-SCons-compat-__init__.py patch-engine-SCons-compat-_scons_subprocess.py Message-ID: <200812251457.mBPEv6XJ034165@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
pgollucci 2008-12-25 14:57:06 UTC
FreeBSD ports repository
Modified files:
devel/scons Makefile
Added files:
devel/scons/files patch-engine-SCons-compat-__init__.py
patch-engine-SCons-compat-_scons_subprocess.py
Log:
Python's subprocess module has a race condition: Popen() constructor has a call to global "_cleanup()" function on whenever a Popen object gets created, and that call causes a check for all pending Popen objects whether their subprocess has exited - i.e. the poll() method is called for every active Popen object.
See http://bugs.python.org/issue1731717 for addition details
SCon's compat/_scons_subprocess.py module is just a copy of a more recent
stock Python subprocess.py modified so it will work with older Python
versions.
The attached patch will add locks around calls to Popen and change
the compat module in a way that the subprocess module is always used, no matter if Python already ships one.
The rationale behind this decision is that there are many Python versions in the wild with different Popen() race condition problems.
PR: ports/128845
Submitted by: Steven Kreuzer <skreuzer@exit2shell.com>
Approved by: araujo (mentor, implicit)
Revision Changes Path
1.35 +1 -0 ports/devel/scons/Makefile
1.1 +29 -0 ports/devel/scons/files/patch-engine-SCons-compat-__init__.py (new)
1.1 +33 -0 ports/devel/scons/files/patch-engine-SCons-compat-_scons_subprocess.py (new)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812251457.mBPEv6XJ034165>