Date: Thu, 26 Jan 2017 05:26:10 +0000 From: Dexuan Cui <decui@microsoft.com> To: Gleb Smirnoff <glebius@FreeBSD.org>, Dexuan Cui <dexuan@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r312687 - in head/sys: net sys Message-ID: <MWHPR03MB266919FF18055E20E8EBFDF7BF770@MWHPR03MB2669.namprd03.prod.outlook.com> In-Reply-To: <MWHPR03MB2669200B143B854A31DE8DAEBF750@MWHPR03MB2669.namprd03.prod.outlook.com> References: <201701240919.v0O9JlM7021007@repo.freebsd.org> <20170124192725.GX2611@FreeBSD.org> <MWHPR03MB2669200B143B854A31DE8DAEBF750@MWHPR03MB2669.namprd03.prod.outlook.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> From: Dexuan Cui [mailto:decui@microsoft.com] > Sent: Wednesday, January 25, 2017 06:21 > To: Gleb Smirnoff <glebius@FreeBSD.org>; Dexuan Cui <dexuan@FreeBSD.org> > Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src- > head@freebsd.org > Subject: RE: svn commit: r312687 - in head/sys: net sys >=20 > > From: Gleb Smirnoff [mailto:glebius@FreeBSD.org] > > Dexuan, > > > > On Tue, Jan 24, 2017 at 09:19:47AM +0000, Dexuan Cui wrote: > > D> --- head/sys/sys/eventhandler.h Tue Jan 24 09:15:36 2017 > > (r312686) > > D> +++ head/sys/sys/eventhandler.h Tue Jan 24 09:19:46 2017 > > (r312687) > > D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc > > D> EVENTHANDLER_DECLARE(swapon, swapon_fn); > > D> EVENTHANDLER_DECLARE(swapoff, swapoff_fn); > > D> > > D> +/* ifup/ifdown events */ > > D> +#define IFNET_EVENT_UP 0 > > D> +#define IFNET_EVENT_DOWN 1 > > D> +struct ifnet; > > D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event= ); > > D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn); > > D> + > > D> #endif /* _SYS_EVENTHANDLER_H_ */ > > > > The network stuff shall not be added to sys/eventhandler.h. > > > > All these declarations should go to net/if_var.h. There is already > > a block of event(9) defines there. Please move it there. > > > > -- > > Totus tuus, Glebius. >=20 > Hi Gleb, > Sorry, I didn't realize this... I'll move it as you suggested. >=20 > Thank you for the reminder! >=20 > -- Dexuan I posted https://reviews.freebsd.org/D9345 for this. Please review it. Thanks, -- Dexuan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?MWHPR03MB266919FF18055E20E8EBFDF7BF770>