Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Dec 2008 22:33:07 +0000 (UTC)
From:      "G. Paul Ziemba" <pz-freebsd-ports@ziemba.us>
To:        freebsd-ports@freebsd.org
Subject:   Re: Proposal: mechanism for local patches
Message-ID:  <gh4d33$a55$1@hairball.ziemba.us>
References:  <20081202201610.GA8753@atarininja.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> [Site-local patches to ports]

wxs@freebsd.org (Wesley Shields) writes:
>On Tue, Dec 02, 2008 at 09:07:43PM +0300, Dmitry Marakasov wrote:
>> Here's the draft patch for this functionality:
>> 
>> http://people.freebsd.org/~amdmi3/local-patchdir.patch

>Other than the above comment I like the patch and would love to see it
>implemented.  I think it can provide a benefit in situations where
>companies/people are doing things with ports that they do not want to
>contribute back.

I, too, am happy with the idea of an administrator-specifiable parallel
tree that would have the same structure as /usr/ports. So this approach
involves, for the administrator (I am restating Dmitry's comments):

    1. in /etc/make.conf, define USE_LOCALPATCHES=<patch-path>
    2. put patches in <patch-path>/<category>/<portname>/patch-*

If I may offer comments on Dmitry's draft patch:

1. Good that it's at the end of the do-patch target - that way local
   patches can happen after the "official" patches

2. I'm not sure we need the test for *.orig|*.rej|*~|*,v, but it
   wouldn't hurt. Maybe it helps admins who are actively developing
   local patches. I see that it's in the existing do-patch code above.

3. Does ${OPSYS} belong in the echoed messages for local patches?


-- 
G. Paul Ziemba
FreeBSD unix:
 2:31PM  up 2 days, 1 min, 8 users, load averages: 1.36, 1.30, 1.33



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?gh4d33$a55$1>