Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Oct 2024 18:39:23 GMT
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 0366d0bd5028 - stable/14 - cxgbe/iw_cxgbe: c4iw_connect should return a negative errno.
Message-ID:  <202410211839.49LIdNVG036778@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by np:

URL: https://cgit.FreeBSD.org/src/commit/?id=0366d0bd50281cff65e3856f238e250dba39adfa

commit 0366d0bd50281cff65e3856f238e250dba39adfa
Author:     Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2024-08-30 00:43:43 +0000
Commit:     Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2024-10-21 17:08:27 +0000

    cxgbe/iw_cxgbe: c4iw_connect should return a negative errno.
    
    Avoid a pointless assignment while here.
    
    Sponsored by:   Chelsio Communications
    
    (cherry picked from commit 3b4dcc0feb41120017381681d612d3cc21beb1d7)
---
 sys/dev/cxgbe/iw_cxgbe/cm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c
index 62961ca88aab..cf4a8f1aa87b 100644
--- a/sys/dev/cxgbe/iw_cxgbe/cm.c
+++ b/sys/dev/cxgbe/iw_cxgbe/cm.c
@@ -2664,8 +2664,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
 
 		CTR2(KTR_IW_CXGBE, "%s:cc7 %p", __func__, ep);
 		printk(KERN_ERR MOD "%s - cannot find route.\n", __func__);
-		err = EHOSTUNREACH;
-		return err;
+		return -EHOSTUNREACH;
 	}
 
 	if (!(if_getcapenable(nh_ifp) & IFCAP_TOE) ||



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202410211839.49LIdNVG036778>