Date: Mon, 19 Oct 2020 17:24:52 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 250461] New port: databases/proxysql ProxySQL is a high performance proxy for MySQL and forks Message-ID: <bug-250461-7788-jqG88MIwbt@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-250461-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-250461-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250461 daniel.engberg.lists@pyret.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.engberg.lists@pyret. | |net --- Comment #1 from daniel.engberg.lists@pyret.net --- Python 2.x is going to be removed in less than 2 months (at the end of the year) so this probably isn't going get committed. As for using vendor provided libs, this is more or less discouraged https://www.freebsd.org/doc/en/books/porters-handbook/book.html#bundled-libs and for a good reason. Looking at vendor repo there's a lot of _very_ old l= ibs with known vulns. https://github.com/sysown/proxysql/tree/v2.0.15/deps Mixing and matching different build frameworks is also less than ideal and = can (probably will) lead to interesting failures. Makefile: L6+L2+29 - Check section 5.4.3 https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-di= stfiles Makefile: L7 - Remove, PORTREVISION starts at 0 and doesn't need to be set. Makefile: L14 - Use tab instead of space (style, consistency) Makefile: L22 - Remove + Makefile: L24 - For the sake of readability use alphabetical order Makefile: L36-37 - No, read section 6.27 https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#users-and-groups Makefile: L58-59 - Looking at L61-L62 just set them directly or just ${PORTNAME} if you insist on using a variable? Makefile: L84 is definitely a no go, that needs to be fixed within the port. Unless it greatly improves readability there's no need to define a variable= and only use it once. portlint will probably find a few issues too https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#testing-portlint A poudriere run will also be very helpful. I'm by far no expert but the mentioned issues above looks incorrect to me at first glance. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-250461-7788-jqG88MIwbt>