Date: Tue, 12 Mar 2019 07:33:15 +0000 From: "hrs (Hiroki Sato)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes. Message-ID: <c2b9489a70bb6207b34091e9e9272b89@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-bvtxxu4jwhzdkwqxxgd7-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-bvtxxu4jwhzdkwqxxgd7-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hrs added a comment.
Adding jumbo frame support looks good to me. However, is it better to support this in ether_ioctl() instead of a driver-specific ioctl handler? Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if the interface has IFCAP_JUMBO_MTU or not.
INLINE COMMENTS
> if_vxlan.c:2273
> + case SIOCSIFMTU:
> + if (ifr->ifr_mtu < ETHERMIN || ifr->ifr_mtu > ETHERMTU_JUMBO) {
> + error = EINVAL;
I think the maximum value should be calculated by considering encap overhead. VXLAN adds a header with 50-100 byte long depending on the outer protocol.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D19422/new/
REVISION DETAIL
https://reviews.freebsd.org/D19422
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: aleksandr.fedorov_itglobal.com, bryanv, hrs, #network, rgrimes
Cc: evgueni.gavrilov_itglobal.com, olevole_olevole.ru, ae, freebsd-net-list, krzysztof.galazka_intel.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c2b9489a70bb6207b34091e9e9272b89>