Date: Tue, 23 Mar 2021 21:05:01 +0000 From: "Scheffenegger, Richard" <Richard.Scheffenegger@netapp.com> To: "tuexen@freebsd.org" <tuexen@freebsd.org>, Alan Somers <asomers@freebsd.org> Cc: Kevin Bowling <kevin.bowling@kev009.com>, FreeBSD Net <freebsd-net@freebsd.org>, "rscheff@freebsd.org" <rscheff@freebsd.org> Subject: AW: tcp-testsuite into src? Message-ID: <SN4PR0601MB37286485BC9449C5EE69CC1D86649@SN4PR0601MB3728.namprd06.prod.outlook.com> In-Reply-To: <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org> References: <CAK7dMtB%2B=Ydo4ziznKxj7qV6TsDUH7EzXbeyj0ZT1=zuJDhD=A@mail.gmail.com> <CAOtMX2ikMjarK0x-wF1RNQvJYQtrrCvLeQAisvES43K6S=zV-A@mail.gmail.com> <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> Yeah, it's not a problem to use binaries from ports in /usr/tests. As=20 >> long as the tests can compile they can live in the base system. Is=20 >> there a strong incentive to import them?=20 > > The tests are just scripts, which can be executed by packetdrill, which i= s available in the ports tree. > >> Do they need to be adjusted for each release? > > It depends. If things like default timeouts or so change, then the tests = need to be adapted. > > If we would have (and I guess we will) tests for loss recovery, then impr= ovements to the code might also require changes to the tests. Yes, I would really like to have the packetdrill scripts in the source tree= . And a recipe, how to run a subtree from the test (e.g. the TCP tests) as = part of a kernel build... As I work on adding newer mechanisms into base stack TCP, I would be docume= nting these changes in microscopic timing etc in terms of test cases... Right now, the test suite is organized in a similar layout of the source fi= les. However, as UDP, TCP and SCTP all live in /sys/netinet, and the existi= ng packetdrill scripts cover a lot of ground in various scenarios, I am won= dering if it wouldn't be easier to have a subdirectory under /tests/sys/net= inet/packetdrill/tcp which mirrors freebsd-net/tcp-testsuite > > Best regards > Michael
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?SN4PR0601MB37286485BC9449C5EE69CC1D86649>