Date: Fri, 13 Dec 2024 09:53:36 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a1097094c4c5 - main - newvers: Set explicit git revision length Message-ID: <e827f951-e747-45d6-b4d8-a74a18734bae@FreeBSD.org> In-Reply-To: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> References: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/13/24 08:06, Ed Maste wrote: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a1097094c4c5d810287aca092f4ab5f9f86a426a > > commit a1097094c4c5d810287aca092f4ab5f9f86a426a > Author: Pat Maddox <pat@patmaddox.com> > AuthorDate: 2024-12-13 05:28:18 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2024-12-13 13:06:10 +0000 > > newvers: Set explicit git revision length > > The --short flag is configurable. Setting an explicit length supports > reproducible builds. > > Signed-off-by: Pat Maddox <pat@patmaddox.com> > Reviewed by: emaste, imp > Differential revision: https://github.com/freebsd/freebsd-src/pull/1547 Hmm, this seems to defeat the purpose of the --short flag. I think if you want this to be reproducible you just need to use the full hash. If we get enough commits that git thinks we need a longer short hash, then truncating the hash to a shorter length here is a bug. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e827f951-e747-45d6-b4d8-a74a18734bae>