Date: Wed, 22 Jan 2014 20:05:09 -0800 From: Adrian Chadd <adrian.chadd@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@felyko.com>, Neel Natu <neel@freebsd.org> Subject: Re: svn commit: r260898 - head/sys/kern Message-ID: <CAJ-VmokgEr1THSfusi3h_3rKaQw4K=MxCOXhFWSB--Lj%2BOB6%2Bw@mail.gmail.com> In-Reply-To: <1536225.gsjt6oXMt2@pippin.baldwin.cx> References: <201401200159.s0K1xa5X012123@svn.freebsd.org> <EA6A69A5-0620-4BF9-9871-268C416D2F58@felyko.com> <1536225.gsjt6oXMt2@pippin.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
.. Make it be an offset into the table rather than a pointer, then we can do dirty rcu style hacks to just replace and grow the table as we need more memory. Don't we have a standard way to pull memory from the top of the physmem area early on for allocations like this? Adrian On Jan 20, 2014 3:50 PM, "John Baldwin" <jhb@freebsd.org> wrote: > On Sunday 19 January 2014 18:18:03 Rui Paulo wrote: > > On 19 Jan 2014, at 17:59, Neel Natu <neel@FreeBSD.org> wrote: > > > Author: neel > > > Date: Mon Jan 20 01:59:35 2014 > > > New Revision: 260898 > > > URL: http://svnweb.freebsd.org/changeset/base/260898 > > > > > > Log: > > > Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient > entries > > > for > > > WITNESS to actually work. > > > > This value should be automatically tuned... > > How do you propose to do so? This is the count of locks initialized before > witness' own SYSINIT is executed and the array it sizes is allocated > statically at compile time. This used to not be a static array, but an > intrusive list embedded in locks themselves, but we decided to shave a > pointer off of each lock that was only used for that and to use a > statically > sized table instead. > > -- > John Baldwin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokgEr1THSfusi3h_3rKaQw4K=MxCOXhFWSB--Lj%2BOB6%2Bw>