Date: Mon, 17 May 2010 10:41:13 -0400 From: Andrew Duane <aduane@juniper.net> To: "C. Jayachandran" <c.jayachandran@gmail.com>, Neel Natu <neelnatu@gmail.com> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: RE: Minor fixup for the MIPS SMP platform code. Message-ID: <AC6674AB7BC78549BB231821ABF7A9AE903E160C21@EMBX01-WF.jnpr.net> In-Reply-To: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com> References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
A really minor nit: in sys/mips/rmi/xlr_machdep.c, you might as well put the assert for "Interrupts enabled" before setting the COP_2 and COP_0 bits in the stat register. There's no real difference of effect, the code just feels a bit cleaner to check for validity before setting anything else. /Andrew > -----Original Message----- > From: owner-freebsd-mips@freebsd.org > [mailto:owner-freebsd-mips@freebsd.org] On Behalf Of C. Jayachandran > Sent: Monday, May 17, 2010 10:33 AM > To: Neel Natu > Cc: freebsd-mips@freebsd.org > Subject: Minor fixup for the MIPS SMP platform code. > > The attached patch (also at > http://sites.google.com/site/cjayachandran/files) > has two changes: > - moves the intr masking code to platform_init_ap, so that we > can avoid the > #ifdef for XLR > - adds a platform_smp_topo() function so that platforms can > define their > topology > > I've also attempted to fixup sys/mips/sibyte to reflect these > changes, but > it might need further work. > sys/mips/cavium also might need similar changes for SMP. > > Please review and apply if the changes are okay. > > Thanks, > JC. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC6674AB7BC78549BB231821ABF7A9AE903E160C21>