Date: Fri, 25 Oct 2013 11:18:36 -0500 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: John Clark <jeclark2006@aim.com> Cc: FreeBSD PowerPC ML <freebsd-ppc@freebsd.org> Subject: Re: Updates to MPC85XX PCI driver Message-ID: <526A99DC.9040406@freebsd.org> In-Reply-To: <FD4CF8C7-3C90-4D57-BF4E-5F52D0104741@aim.com> References: <52669D8A.8020302@freebsd.org> <FD4CF8C7-3C90-4D57-BF4E-5F52D0104741@aim.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/22/13 11:27, John Clark wrote: > On Oct 22, 2013, at 8:45 AM, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > >> I've been going through our tree trying to remove code duplication between AIM and Book-E, as people attentive to the commit logs might have seen. At the same time, I'm also trying to deduplicate the FDT and OFW code, since they are implementing many of the same interfaces and specifications. As part of that, I've adapted the MPC85XX PCI driver to use the generic ofw_pci code, which gives a quite substantial reduction in the driver and also substantially improves its robustness to variations on the device tree setup: >> http://people.freebsd.org/~nwhitehorn/pci_mpc85xx.diff >> >> I can currently only test this patch in QEMU, where it works fine, and there should be no functional changes at all, but tests on real hardware would be appreciated. If I don't hear anything, I'll commit this at the end of the week. >> -Nathan > I had quite a bit of problem with PCI and the P1020WLAN eval board, which is based on the MPC85XX processor 'class'. Unfortunately right at the moment I've had to return to updated my OpenWRT linux environment, so perhaps next week I can 'test' what you have on my hardware. > > John Clark. > > > > I've gone ahead and committed this patch, but have my finger squarely on the revert button in case there is any fallout in more complex situations than I was able to test. Please tell me if so as soon as possible. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?526A99DC.9040406>