Date: Sun, 09 Sep 2012 17:26:18 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Martin Matuska <mm@freebsd.org>, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r240225 - stable/9/sys/cddl/compat/opensolaris/sys Message-ID: <504D33AA.8010707@FreeBSD.org> In-Reply-To: <CAF6rxgmDRZ=ZaDMF6PJCjYdDPVCcw-zaRXff_zEeD8v_Ciw5MQ@mail.gmail.com> References: <201209080241.q882foC1005948@svn.freebsd.org> <504B9AC3.2070705@FreeBSD.org> <504B9E4C.6030301@FreeBSD.org> <CAF6rxgmDRZ=ZaDMF6PJCjYdDPVCcw-zaRXff_zEeD8v_Ciw5MQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/8/2012 12:39 PM, Eitan Adler wrote:
> On 8 September 2012 15:36, Doug Barton <dougb@freebsd.org> wrote:
>> On 09/08/2012 12:21, Martin Matuska wrote:
>>> This commit is missing the PR number
>>
>> It's actually pretty common to summarize the commit message in an MFC,
>> rather than reproducing it verbatim.
>
> The PR number is still important in order for dfilter to act
> correctly.
While reasonable minds can differ on this topic, I regard that as a
reason _not_ to include the PR number in merges. IMO it's far better to
have one line "MFCs complete" than it is to repeat the same commit
message verbatim in GNATS N times.
Doug
--
I am only one, but I am one. I cannot do everything, but I can do
something. And I will not let what I cannot do interfere with what
I can do.
-- Edward Everett Hale, (1822 - 1909)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?504D33AA.8010707>